Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: pip freeze no longer protects setuptools, distribute or wheel on Python 3.12 #2104

Open
ncoghlan opened this issue Jun 23, 2024 · 7 comments · May be fixed by #2105
Open

Test failure: pip freeze no longer protects setuptools, distribute or wheel on Python 3.12 #2104

ncoghlan opened this issue Jun 23, 2024 · 7 comments · May be fixed by #2105
Labels
bug Something is not working pip Related to pip sync tests Testing and related things

Comments

@ncoghlan
Copy link

ncoghlan commented Jun 23, 2024 •
edited

Some CI tests are failing due to this change in pip to no longer protect setuptools, distribute or wheel by default on Python 3.12 : pypa/pip@5dc65ea

That has been in the pip dev branch for a while, and was published in pip 24.1 in the past few days.

This change affects the pip-tools test suite by way of the PACKAGES_TO_IGNORE value, which reads the pip freeze internal API via

pip-tools/piptools/_compat/pip_compat.py

Line 101 in 5330964

Simplest CI fix would likely be to drop those packages from the affected test cases, since their handling depends on the versions of other components.
@ncoghlan ncoghlan mentioned this issue Jun 23, 2024
Open
@ncoghlan
Copy link
Author

ncoghlan commented Jun 23, 2024 •
edited

The test_compile_recursive_extras_build_targets failure feels like it might be due to pypa/pip#12449 (pip used to inject wheel as an implicit build dependency for every setup.py project)

ncoghlan added a commit to ncoghlan/pip-tools that referenced this issue Jun 23, 2024
@ncoghlan
CI: Avoid a pip behaviour dependency in test_sync
ec585c5 
Closes jazzband#2104
@ncoghlan ncoghlan linked a pull request Jun 23, 2024 that will close this issue
Open
4 tasks
@chrysle chrysle added bug Something is not working tests Testing and related things pip Related to pip sync labels Jun 23, 2024
@chrysle
Copy link
Contributor

chrysle commented Jun 24, 2024

Some CI tests are failing due to this change in pip to no longer protect setuptools, distribute or wheel by default on Python 3.12 : pypa/pip@5dc65ea

We don't test on 3.12 yet, though...

@chrysle chrysle mentioned this issue Jun 25, 2024
Open
4 tasks
@chrysle
Copy link
Contributor

chrysle commented Jun 25, 2024

The test_compile_recursive_extras_build_targets failure feels like it might be due to pypa/pip#12449 (pip used to inject wheel as an implicit build dependency for every setup.py project)

True, I've opened a PR, but there are still the failing Windows tests... Could you look into them?

@ncoghlan
Copy link
Author

We don't test on 3.12 yet, though...

I hit this one locally when trying to reproduce the other CI failures. I didn't check if the GitHub CI was running 3.12.

@webknjaz
Copy link
Member

webknjaz commented Jul 7, 2024

The test_compile_recursive_extras_build_targets failure feels like it might be due to pypa/pip#12449 (pip used to inject wheel as an implicit build dependency for every setup.py project)

@ncoghlan no, apparently, this is because @agronholm moved wheel into setuptools during the sprints at PyCon US this spring. That failure actually led me to discovering a bug in the feature the failing test checks: #1681 (comment) / https://github.com/jazzband/pip-tools/pull/1681/files#r1667748889.

@ncoghlan ncoghlan changed the title CI failure: pip freeze no longer protects setuptools, distribute or wheel on Python 3.12 Test failure: pip freeze no longer protects setuptools, distribute or wheel on Python 3.12 Jul 8, 2024
@ncoghlan
Copy link
Author

ncoghlan commented Jul 8, 2024

Fixed the issue title to reflect that this isn't a CI issue (yet)

@ncoghlan
Copy link
Author

ncoghlan commented Jul 8, 2024

From a windows testing point of view, I just ran tox -e piplatest locally, and the only reported failures were this (which I fixed by switching to my PR branch) and the wheel related failure that #2106 attempted to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working pip Related to pip sync tests Testing and related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Reduce pip behaviour dependencies in test suite ncoghlan/pip-tools
3 participants
@webknjaz @ncoghlan @chrysle