Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cors] Use JDK's URI class #2180

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

[cors] Use JDK's URI class #2180

wants to merge 14 commits into from

Conversation

Playacem
Copy link
Member

@Playacem Playacem commented Mar 4, 2024

Todos:

  • tests for IPv4 addresses as an origin
  • tests for IPv6 addresses as an origin
  • harden port extraction especially for IPv6 addresses
  • Use URI class for port logic
  • complete plugin tests for IP address based origins

Fixes #2138 (once its done)

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.47%. Comparing base (b7be1bd) to head (8740c5c).

Files Patch % Lines
...c/main/java/io/javalin/plugin/bundled/CorsUtils.kt 88.57% 0 Missing and 4 partials ⚠️
.../main/java/io/javalin/plugin/bundled/CorsPlugin.kt 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2180       /-   ##
============================================
  Coverage     86.32%   86.47%    0.14%     
- Complexity     1309     1328       19     
============================================
  Files           148      148              
  Lines          4038     4073       35     
  Branches        508      518       10     
============================================
  Hits           3486     3522       36     
  Misses          333      331       -2     
- Partials        219      220        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tipsy tipsy force-pushed the master branch 4 times, most recently from 765b7d0 to 6faa186 Compare May 8, 2024 16:19
@tipsy
Copy link
Member

tipsy commented Jul 5, 2024

How is this PR going @Playacem ?

@Playacem
Copy link
Member Author

Playacem commented Jul 6, 2024

I have been quite busy with real life, but I finally have some time this weekend to work on it.

@tipsy
Copy link
Member

tipsy commented Jul 6, 2024

I have been quite busy with real life, but I finally have some time this weekend to work on it.

Me too, no rush ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cors] Use JDK'S URI class for origin parsing
2 participants
@Playacem @tipsy