take into account #spill/#unspill in sct checker #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
reviewed
Apr 17, 2024
compiler/src/sct_checker_forward.ml
Outdated
| let sx = Env.add_spill env x in | ||
| do_local venv sx in | ||
|
|
||
| let venv = List.fold_left do_spill venv (Sv.elements (spilled f)) in |
There was a problem hiding this comment.
yes I will change that.
tfaoliveira-sb
added a commit
to formosa-crypto/formosa-mlkem
that referenced
this pull request
Apr 18, 2024
|
Why don’t we just get rid of these fishy spill/unspill stuff? |
vbgl
approved these changes
Apr 26, 2024
|
I really feel that this spill/unspill feature is poorly designed and that there is wide room for improvement. |
|
Thank for the merge, I will be very happy to discuss of different possibilities for improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.