Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import_typescript.default.isTokenKind is not a function #923

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: import_typescript.default.isTokenKind is not a function #923

merged 1 commit into from
Dec 8, 2023

Conversation

louis-jan
Copy link
Contributor

Description

  • Failed to compile due to typescript dependencies conflict

@github-actions github-actions bot added the type: bug Something isn't working label Dec 8, 2023
@tikikun tikikun self-requested a review December 8, 2023 14:21
tikikun
tikikun approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@tikikun tikikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit 8bde944 into main Dec 8, 2023
3 checks passed
@louis-jan louis-jan deleted the fix/dev-dependencies-error branch December 8, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikikun tikikun tikikun approved these changes

@urmauur urmauur Awaiting requested review from urmauur

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @tikikun