Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: jan extensions #799

Merged
merged 2 commits into from
Dec 1, 2023
Merged

refactor: jan extensions #799

merged 2 commits into from
Dec 1, 2023

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 30, 2023 •
edited
Loading

Descriptions

  • Rename entities/folders (plugins -> extensions)
  • Refactor preload invokers & handlers (no more heavy preload.ts)
  • Refactor extension manager from main host to corresponding module (no more facade, global, router)
  • Clean exposed core (no more window.coreAPI, window.corePlugin, pluggableElectron)
  • No more /core in electron directory (less confuse, only one root core dir)
  • Less Events (only OnMessageSent, OnMessageResponse, OnMessageUpdate for now)
  • Move /extensions to user's jan directory ~/jan

This PR is a part of #791

Next Action Items:

  • Provide entry points & TODOs

@louis-jan louis-jan linked an issue Nov 30, 2023 that may be closed by this pull request
refactor: scaffold new architecture at a high level #791
Closed
@louis-jan
Copy link
Contributor Author

Will explain more ^

@louis-jan louis-jan requested review from namchuai, 0xSage and a team and removed request for namchuai November 30, 2023 16:07
@louis-jan louis-jan force-pushed the 791-refactor-scaffold-new-architecture-at-a-high-level branch 2 times, most recently from 5e09425 to c98293e Compare December 1, 2023 02:54
@0xSage 0xSage added the type: chore Maintenance, operational label Dec 1, 2023
@louis-jan louis-jan force-pushed the 791-refactor-scaffold-new-architecture-at-a-high-level branch from c98293e to c3e298f Compare December 1, 2023 03:35
@louis-jan
Copy link
Contributor Author

@janhq/engineers scheduled to merge this asap to avoid further conflict (mostly about Plugin to Extension terminology update) cc @0xSage

@louis-jan louis-jan removed a link to an issue Dec 1, 2023
refactor: scaffold new architecture at a high level #791
Closed
@louis-jan louis-jan force-pushed the 791-refactor-scaffold-new-architecture-at-a-high-level branch from c3e298f to 992ea41 Compare December 1, 2023 04:17
@louis-jan louis-jan merged commit 1143bd3 into main Dec 1, 2023
3 checks passed
@louis-jan louis-jan deleted the 791-refactor-scaffold-new-architecture-at-a-high-level branch December 1, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSage 0xSage 0xSage approved these changes

Assignees

@louis-jan louis-jan

Labels
type: chore Maintenance, operational
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @0xSage