Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clarification changes to the model settings and model parameters #742

Merged
merged 5 commits into from
Nov 29, 2023
Merged

chore: clarification changes to the model settings and model parameters #742

merged 5 commits into from
Nov 29, 2023

Conversation

tikikun
Copy link
Contributor

@tikikun tikikun commented Nov 28, 2023

Descriptive example with correct reference to nitro docs for:

  • Model parameters
  • Model settings

@tikikun tikikun requested a review from a team November 28, 2023 04:03
@tikikun tikikun self-assigned this Nov 28, 2023
@tikikun tikikun linked an issue Nov 28, 2023 that may be closed by this pull request
chore: Adding correct example for model parameters with examples #741
Closed
@github-actions GitHub Actions
Copy link
Contributor

Preview URL: https://4c6aea5b.jan-qn8.pages.dev

0xSage
0xSage reviewed Nov 28, 2023
View reviewed changes
docs/docs/specs/models.md Outdated
},
"metadata": {}, // Defaults to {}
"assets": [ // Defaults to current dir
"file://.../zephyr-7b-q4_k_m.bin",
]
```

The model settings in the example can be found at: (Nitro's model settings)[https://nitro.jan.ai/features/load-unload#table-of-parameters]

The model paramemters in the example can be found at: (Nitro's model parameters)[https://nitro.jan.ai/api-reference#tag/Chat-Completion]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Mispelled parameters
  2. URL formatting is wrong, shouldn't it be , not ()[]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @0xSage i have fixed the link issue, but what you mean by parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm saw the issue

@tikikun tikikun merged commit 4c2c320 into main Nov 29, 2023
1 check failed
@tikikun tikikun deleted the 741-chore-adding-correct-example-for-model-parameters-with-examples branch November 29, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSage 0xSage 0xSage left review comments

@louis-jan louis-jan louis-jan approved these changes

Assignees

@tikikun tikikun

Labels
None yet
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: Adding correct example for model parameters with examples
3 participants
@tikikun @0xSage @louis-jan