-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: assistant spec #707
docs: assistant spec #707
Conversation
Preview URL: https://06c1f680.jan-qn8.pages.dev |
docs/docs/specs/assistants.md
Outdated
|
||
### Example | ||
- Jan Assistant json | ||
TBU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
docs/docs/specs/assistants.md
Outdated
/jan | ||
/models/ | ||
/threads/ | ||
threads-1/ # jan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is folder naming scheme? threads unix timestamp? or just enumeration (not optimal)
docs/docs/specs/assistants.md
Outdated
@@ -25,34 25,84 @@ _Users can configure assistant settings_ | |||
- `assistant.json` | |||
> OpenAI Equivalen: https://platform.openai.com/docs/api-reference/assistants/object | |||
|
|||
// KIV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put KIV / v2 v3 items in a github issue, not the spec itself
docs/docs/specs/assistants.md
Outdated
@@ -16,7 16,7 @@ _Users can import an assistant from local directory_ | |||
|
|||
- Wireframes here | |||
|
|||
_Users can configure assistant settings_ | |||
_Users can configure assistant settings_ | |||
|
|||
- Wireframes here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these comments. Please see the latest spec/models, spec/threads for a cleaned up format that should be pushed to public site.
docs/docs/specs/assistants.md
Outdated
// If model is specified, then use the below | ||
// omitted means default | ||
"models": [ | ||
{ "model_id": "", ..., "parameters": {} } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is itmodel_id
or id
? It's the nested model object right?
docs/docs/specs/assistants.md
Outdated
"out": ["assistant:asst_abc123", "jan:*"] | ||
}, | ||
// Alternate: Simplified version? | ||
"events": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we mention in the call to leave this out of current spec? Lets move to github issue to track this better :)
docs/docs/specs/assistants.md
Outdated
/src | ||
index.js | ||
process.js | ||
/threads # if developer specifies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omit from current spec please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets create an issue to track it instead
No description provided.