Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local npm module update does not reflect web app #677

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 21, 2023

Description

This PR is to address these issues:

  • - Engs find it is very hard to have core or uikit modules update reflect the web app
  • - Inference errors are not output to file which is hard to trace the issue
  • - Switch between conversations quickly will prompt user a bunch of errors
  • - inferenceRequest exported from extension return any value
  • - Inference extension should expose more abstracted functions such as stopInference, loadModel(with: parameters), ...
  • - Clearer error message to user when they use a wrong Nitro binary (different arch)

@louis-jan
Copy link
Contributor Author

Added stopInference() cc @urmauur

@louis-jan louis-jan marked this pull request as ready for review November 22, 2023 14:50
@louis-jan louis-jan force-pushed the chore/log-output-to-file-for-debugging branch from d5e8242 to 492d73f Compare November 22, 2023 14:50
@louis-jan louis-jan merged commit d0c44f7 into main Nov 22, 2023
3 checks passed
@louis-jan louis-jan deleted the chore/log-output-to-file-for-debugging branch November 22, 2023 15:36
@louis-jan louis-jan added type: bug Something isn't working type: chore Maintenance, operational labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: chore Maintenance, operational
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants