Enhance Cross-Platform Argument Handling for Nitro Startup Scripts #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiento09
force-pushed
the
chore/patch-nitro-argument-windows
branch
from
d839aee
to
9183595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces enhancements to the startup scripts for the Nitro application, ensuring consistent argument handling across both Linux and Windows environments.
Changes Made:
Windows (start_nitro.bat): Similar to the Linux script, the batch file now properly handles command-line arguments. It passes any provided arguments to
nitro.exeand includes logic to handle errors by attempting to run an alternative executable in a different directory if the first attempt fails.Purpose:
These changes ensure that both the Linux and Windows scripts behave consistently in terms of argument handling, enhancing the user experience and ensuring that Nitro can be launched with the necessary parameters in different operating system environments.