Fix: specs revision #649
Merged
Fix: specs revision #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-v
added
P0: critical
hiro-v
commented
Nov 18, 2023
hiro-v
force-pushed
the
feat_specs_model
branch
from
2769492
to
dd03fd2
Compare
| @@ -46,7 46,7 @@ _Users can override run settings at runtime_ | |||
| | `object` | enum: `model`, `assistant`, `thread`, `message` | Type of the Jan Object. Always `model` | Defaults to "model" | | |||
| | `name` | string | A vanity name | Defaults to filename | | |||
| | `description` | string | A vanity description of the model | Defaults to "" | | |||
| | `state` | enum[`running` , `stopped`, `not-downloaded` , `downloading`] | Needs more thought | Defaults to `not-downloaded` | | |||
| | `state` | enum[`to_download` , `downloading`, `ready` , `running`] | Needs more thought | Defaults to `to_download` | | |||
There was a problem hiding this comment.
@vuonghoainam @0xSage It may be wiser to have null represent the to_download state (vs. a default)
There was a problem hiding this comment.
WIll approve first but let's discuss subsequently
dan-homebrew
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.