Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused hooks and resolve no-explicit-any #647

Merged
merged 4 commits into from
Nov 20, 2023
Merged

refactor: remove unused hooks and resolve no-explicit-any #647

merged 4 commits into from
Nov 20, 2023

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 17, 2023 •
edited
Loading

Descriptions

This is to remove unused hooks and states also refactor unknown/any type passed around:

  • Model plugin's parseToModel parse unknown object and return any model
  • Product Detail & Advanced Prompt are no longer relevant
  • No more hacky delayed message send, since we use ULID instead of unix timestamp as ID
  • Toast messages typo
  • Fix convo summary

@louis-jan louis-jan force-pushed the chore/refactor-unused-hooks-no-explicit-any branch 2 times, most recently from ad5489a to 55a1765 Compare November 17, 2023 09:06
@louis-jan louis-jan force-pushed the chore/refactor-unused-hooks-no-explicit-any branch from 55a1765 to fd0125a Compare November 20, 2023 02:13
namchuai
namchuai approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@louis-jan louis-jan marked this pull request as ready for review November 20, 2023 02:39
@louis-jan louis-jan merged commit c9cfebd into main Nov 20, 2023
3 checks passed
@louis-jan louis-jan deleted the chore/refactor-unused-hooks-no-explicit-any branch November 20, 2023 02:39
@louis-jan louis-jan added type: chore Maintenance, integration, packaging related type: bug Something isn't working labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working type: chore Maintenance, integration, packaging related
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-jan @urmauur @namchuai