Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model specs #641

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Model specs #641

merged 8 commits into from
Nov 17, 2023

Conversation

hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Nov 16, 2023 •
edited
Loading

@hiro-v hiro-v added P1: important Important feature / fix type: documentation Improvements or additions to documentation type: chore Maintenance, integration, packaging related labels Nov 16, 2023
@hiro-v hiro-v added this to the Jan V2.0.0 milestone Nov 16, 2023
@hiro-v hiro-v requested a review from a team November 16, 2023 09:14
@hiro-v hiro-v self-assigned this Nov 16, 2023
@hiro-v hiro-v changed the title [WIP] Model specs Model specs Nov 16, 2023
@dan-homebrew
Copy link
Contributor

@vuonghoainam Can you link the HackMD for edits/comments in the PR?

dan-homebrew
dan-homebrew approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@dan-homebrew dan-homebrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept initial changes, for review over weekend

@dan-homebrew dan-homebrew merged commit 368f175 into main Nov 17, 2023
1 check failed
@dan-homebrew dan-homebrew deleted the feat_specs_model branch November 17, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-homebrew dan-homebrew dan-homebrew approved these changes

@0xSage 0xSage Awaiting requested review from 0xSage

Assignees

@hiro-v hiro-v

Labels
P1: important Important feature / fix type: chore Maintenance, integration, packaging related type: documentation Improvements or additions to documentation
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiro-v @dan-homebrew @0xSage