fix: #3667 - The recommended label should be hidden #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 57.31%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
urmauur
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It can be confusing when a recommended tag is applied to all models using the
model size < available RAM/VRAMformula, because in reality, these models can still perform slowly on users' machines due to lack of GPU acceleration and the need to handle large contexts.Decision
Hide the "Recommended" tag in the Hub and only display compatibility tags for models that are marked as "Slow on your device" or "Not enough RAM".
Fixes Issues
Recommendedtag in Hub #3667Screenshots
Changes made
Changes in
ModelLabel.test.tsx:Three test cases are defined to cover different scenarios:
* The first test case checks if the
ModelLabelcomponent renders theNotEnoughMemoryLabelwhen the minimum RAM model is greater than the total RAM.* The second test case checks if the
ModelLabelcomponent renders theSlowOnYourDeviceLabelwhen the minimum RAM model is less than the total RAM but greater than the available RAM.* The third test case checks if the
ModelLabelcomponent renders nothing when the minimum RAM model is less than the available RAM.Changes in
index.tsx:index.tsxfile has been updated to remove theRecommendedLabelimport and component invocation.ModelLabelcomponent's logic has been updated to only render theSlowOnYourDeviceLabelwhen the minimum RAM model is less than the total RAM and the available RAM. TheRecommendedLabelcomponent is no longer conditionally rendered.