feat: modal migration UI #3153
Merged
feat: modal migration UI #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
force-pushed
the
feat/migration-ui
branch
from
2f90a8c
to
2fd8dea
Compare
urmauur
force-pushed
the
feat/migration-ui
branch
from
2fd8dea
to
e1fab6e
Compare
namchuai
reviewed
Jul 11, 2024
web/hooks/useMigratingData.ts
Outdated
| } | ||
| const threadTitle: string = thread.title ?? 'New Thread' | ||
| const instruction: string = thread.assistants[0]?.instruction ?? '' | ||
| if (!threadsMessagesMigrationSuccess) { |
There was a problem hiding this comment.
I think we can use early return here.
if (threadsMessagesMigrationSuccess) return
and, I think we can check this earlier, right? before getting getJanThreadsAndMessages
|
looks good to me but I think we need @Van-QA to test it |
|
@urmauur. The blue check from your screenshot should be green to indicate the completion right? can you double check the Figma? |
@Van-QA updated design, and since checkbox is using variable css 
|
namchuai
pushed a commit
that referenced
this pull request
Jul 18, 2024
* feat: handle popup migration * chore: update loader * chore: integrate script migration * chore: cleanup import * chore: moving out spinner loader * chore: update check thread message success migrate * chore: add handle script into retry button
namchuai
pushed a commit
that referenced
this pull request
Jul 25, 2024
* feat: handle popup migration * chore: update loader * chore: integrate script migration * chore: cleanup import * chore: moving out spinner loader * chore: update check thread message success migrate * chore: add handle script into retry button
namchuai
pushed a commit
that referenced
this pull request
Jul 26, 2024
* feat: handle popup migration * chore: update loader * chore: integrate script migration * chore: cleanup import * chore: moving out spinner loader * chore: update check thread message success migrate * chore: add handle script into retry button
urmauur
added a commit
that referenced
this pull request
Jul 26, 2024
* feat: handle popup migration * chore: update loader * chore: integrate script migration * chore: cleanup import * chore: moving out spinner loader * chore: update check thread message success migrate * chore: add handle script into retry button
Van-QA
added a commit
that referenced
this pull request
Jul 26, 2024
* feat: integrating cortex * Temporary prevent crash Signed-off-by: James <[email protected]> * fix yarn lint Signed-off-by: James <[email protected]> * refactor: remove core node module - fs - extensions and so on (#3151) * add migration script for threads, messages and models Signed-off-by: James <[email protected]> * remove freq_penalty and presence_penalty if model not supported Signed-off-by: James <[email protected]> * add back models in my models Signed-off-by: James <[email protected]> * fix api-url for setup API key popup Signed-off-by: James <[email protected]> * fix using model name for dropdown model Signed-off-by: James <[email protected]> * fix can't click to hotkey Signed-off-by: James <[email protected]> * fix: disable some UIs Signed-off-by: James <[email protected]> * fix build Signed-off-by: James <[email protected]> * reduce calling HF api Signed-off-by: James <[email protected]> * some ui update Signed-off-by: James <[email protected]> * feat: modal migration UI (#3153) * feat: handle popup migration * chore: update loader * chore: integrate script migration * chore: cleanup import * chore: moving out spinner loader * chore: update check thread message success migrate * chore: add handle script into retry button * remove warning from joi Signed-off-by: James <[email protected]> * chore: fix duplicate children * fix: path after migrating model Signed-off-by: James <[email protected]> * chore: apply mutation for config * chore: prevent calling too many create assistant api Signed-off-by: James <[email protected]> * using cortexso Signed-off-by: James <[email protected]> * update download api Signed-off-by: James <[email protected]> * fix use on slider item Signed-off-by: James <[email protected]> * fix: ui no download model or simple onboarding (#3166) * fix download huggingface model match with slider item Signed-off-by: James <[email protected]> * update owner_logo to logo and author Signed-off-by: James <[email protected]> * update new cortexso Signed-off-by: James <[email protected]> * Add install python step for macos * add engine table Signed-off-by: James <[email protected]> * fix local icons Signed-off-by: James <[email protected]> * feat: add search feature for model hub Signed-off-by: James <[email protected]> * fix misalign switch Signed-off-by: James <[email protected]> * fix: delete thread not focus on other thread Signed-off-by: James <[email protected]> * add get model from hugging face Signed-off-by: James <[email protected]> * fix download from hugging face Signed-off-by: James <[email protected]> * small update Signed-off-by: James <[email protected]> * update Signed-off-by: James <[email protected]> * fix system monitor rounded only on the left Signed-off-by: James <[email protected]> * chore: update ui new hub screen (#3174) * chore: update ui new hub screen * chore: update layout centerpanel thread and hub screen * chore: update detail model by group * update cortexso 0.1.13 Signed-off-by: James <[email protected]> * chore: add file size Signed-off-by: James <[email protected]> * chore: put engine to experimental feature Signed-off-by: James <[email protected]> * chore: open cortex folder Signed-off-by: James <[email protected]> * chore: add back user avatar Signed-off-by: James <[email protected]> * chore: minor UI hub (#3182) * chore: add back right click thread list and update 3 dots are overlapping with the text * chore: update position dropdown list my models * chore: make on-device tab showing 6 items instead of 4 * chore: update style description modals detail model * chore: update isGeneration loader and author name on modal * feat: integrate cortex single executable Signed-off-by: James <[email protected]> * fix build Signed-off-by: James <[email protected]> * chore: added blank state * chore: update ui component blank state * bump cortex binary version * fix: logic show modal migration (#3165) * fix: logic show modal migration * chore: fixed logic * chore: read contain format gguf local models * chore: change return hasLocalModel * chore: intiial skipmigration state * chore: filter embedding model * fix: delete top thread not focus on any other thread * chore: added UI no result component search models group (#3188) * fix: remote model should show all when user config that engine Signed-off-by: James <[email protected]> * chore: set state thread and models migration using getOnInit (#3189) * chore: set state thread and models migration using getOnInit * chore: add state as dependecies hooks * chore: system monitor panel show engine model (#3192) * fix: remove config api, replace with engine Signed-off-by: James <[email protected]> * update Signed-off-by: James <[email protected]> * update reactquery Signed-off-by: James <[email protected]> * bump cortex 0.4.35 * feat: add waiting for cortex popup Signed-off-by: James <[email protected]> * chore: add loader detail model popup (#3195) * chore: model start loader (#3197) * chore: added model loader when user starting chat without model active * chore: update copies loader * fix: select min file size if recommended quant does not exist Signed-off-by: James <[email protected]> * chore: temporary hide gpu config * fix: tensorrt not shown Signed-off-by: James <[email protected]> * fix lint Signed-off-by: James <[email protected]> * fix tests Signed-off-by: James <[email protected]> * fix e2e tests (wip) Signed-off-by: James <[email protected]> * update Signed-off-by: James <[email protected]> * fix: adding element and correct test to adapt new UI * fix: temp skip unstable part * fix: only show models which can be supported Signed-off-by: James <[email protected]> * Update version.txt * update send message Signed-off-by: James <[email protected]> * fix: not allow user send message when is generating Signed-off-by: James <[email protected]> * chore: temp skip Playwright test due to env issue * chore: temp skip Playwright test due to env issue * update Signed-off-by: James <[email protected]> * chore: minor-ui-feedback (#3202) --------- Signed-off-by: James <[email protected]> Co-authored-by: Louis <[email protected]> Co-authored-by: Faisal Amir <[email protected]> Co-authored-by: Hien To <[email protected]> Co-authored-by: Van Pham <64197333 [email protected]> Co-authored-by: Van-QA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist