Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate Devbox shell for virtualized local development #3122

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

myrtleTree33
Copy link

@myrtleTree33 myrtleTree33 commented Jun 30, 2024

Use Devbox shell for isolating dependency installs

Hi, I would like to introduce Devbox Shell to make it easier to contribute to Jan AI code. Devbox shell offers a local virtualized environment (similar to Pyenv) that allows me to install dependencies such as Node, without corrupting my PATH and Node versions.

Why not use ASDF

Allows for future proofing, if we need to virtualise other dependencies such as Python in future

Why not use VSCode Dev Containers

We evaluated this in my company previously, found it was not as performant and half-baked in terms of features, documentation and support, compared to Devbox Shell / Nix

Benefit to the community

I can just run devbox shell to get the requirements set up. In future someone can add scripts to preconfig the environment where needed, without messing up the environment. (The make clean is rather lengthy and could be improved IMO).

Installation

  • Clone the Jan repository

  • Run devbox shell to install X version of Node Yarn

  • Run make dev or equivalent

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

urmauur and others added 14 commits June 17, 2024 21:53
* add time weighted retrieval

* add missing configuration for timeWeightedVectorStore

* resolving conflict

* add missing configuration for timeWeightedVectorStore

* resolving conflict

* fix linting issues

* fix build failed due to requirement for useTimeWeightedRetriever in AssistantTool

* update web packages complying the new structure

---------

Co-authored-by: thu <[email protected]>
c‌hor‌e: Sync main to dev 0.5.1
* Update cortex cpp nightly to version 0.4.17

* update linux downloadnitro

* c‌ortex 0.4.18

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Van Pham <64197333 [email protected]>
infomation -> information
* fix: handle long thread title without space, and make searchbar autofocus inside model dropdown

* feat: enable right click to show setting on thread items (janhq#3108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants