Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scan the models folder recursive to find model metadata file #2982

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: scan the models folder recursive to find model metadata file #2982

merged 1 commit into from
Jun 4, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Jun 3, 2024

Describe Your Changes

  • Some user registered models are not found because of \. This PR will help scanning the models folder recursively to find the metadata.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested review from louis-jan and hiro-v June 3, 2024 05:41
@github-actions github-actions bot added the type: bug Something isn't working label Jun 3, 2024
@namchuai namchuai requested a review from Van-QA June 3, 2024 05:41
@namchuai namchuai mentioned this pull request Jun 3, 2024
Merged
3 tasks
louis-jan
louis-jan approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA force-pushed the fix/scan-recursively-for-modeljson branch from 9fd7885 to b3af640 Compare June 3, 2024 08:31
@namchuai namchuai force-pushed the fix/scan-recursively-for-modeljson branch from b3af640 to d9a9a8b Compare June 3, 2024 10:37
@namchuai namchuai merged commit d7f161f into dev Jun 4, 2024
7 checks passed
@namchuai namchuai deleted the fix/scan-recursively-for-modeljson branch June 4, 2024 03:14
@github-actions github-actions bot added this to the v.0.5.1 🍖 Kebap milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@hiro-v hiro-v Awaiting requested review from hiro-v

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v.0.5.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@namchuai @louis-jan @Van-QA