Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: max_tokens and ctx_len max value will follow model.json #2961

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: max_tokens and ctx_len max value will follow model.json #2961

merged 1 commit into from
May 29, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • max_tokens and ctx_len max value will follow model.json

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label May 29, 2024
louis-jan
louis-jan approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai force-pushed the fix/update-max-value-for-slider branch from a2bafb1 to 84145fe Compare May 29, 2024 06:43
@namchuai namchuai merged commit 540999c into dev May 29, 2024
17 checks passed
@namchuai namchuai deleted the fix/update-max-value-for-slider branch May 29, 2024 08:19
@github-actions github-actions bot added this to the v.0.5.0 🍵 Bubur Ayam milestone May 29, 2024
@namchuai namchuai mentioned this pull request May 29, 2024
Closed
@Van-QA
Copy link
Contributor

Van-QA commented May 29, 2024

#2953

@FilterJoe
Copy link

FilterJoe commented Jun 3, 2024 •
edited
Loading

max_tokens and ctx_len still not following model.json after upgraded to 0.50 today (June 3, 8:00 AM PST). Same behavior as prior versions:

When starting a new thread, defaults to 2048 for both max_tokens and ctx_len no matter what is in model.json.

Mac Mini m2 Pro 16GB RAM, MacOS 13.6.6

@namchuai
Copy link
Contributor Author

namchuai commented Jun 4, 2024

@FilterJoe , max_tokens and ctx_len in model.json is indicating the maximum value.
We are working on preset feature, which is allow user to create their own preset and apply it in other models or threads.

I hope this help! Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v.0.5.0 🍵 Bubur Ayam
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@namchuai @Van-QA @FilterJoe @louis-jan