Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NVIDIA API to new jan after jan rework #2934

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Added NVIDIA API to new jan after jan rework #2934

merged 3 commits into from
Jun 4, 2024

Conversation

Realmbird
Copy link
Contributor

@Realmbird Realmbird commented May 21, 2024 •
edited by namchuai
Loading

Describe Your Changes

  • Adding support for nVidia NIM. More information can be found here.

Videos

Screen.Recording.2024-06-04.at.11.13.07.mov

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@Realmbird Realmbird marked this pull request as draft May 21, 2024 16:08
@namchuai
Copy link
Contributor

namchuai commented Jun 3, 2024

This PR will work after this PR is merged: #2982
However, I think databricks/dbrx-instruct is not there. This curl does not work:

curl 'https://integrate.api.nvidia.com/v1/chat/completions' \
  -H 'authority: integrate.api.nvidia.com' \
  -H 'accept: application/json' \
  -H 'accept-language: en-US' \
  -H 'access-control-allow-origin: *' \
  -H 'api-key: your_api_goes_here' \
  -H 'authorization: Bearer your_api_goes_here' \
  -H 'content-type: application/json' \
  -H 'referer: http://localhost:3000/' \
  -H 'sec-ch-ua: "Not_A Brand";v="8", "Chromium";v="120"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: cross-site' \
  -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Jan/0.1.3 Chrome/120.0.6099.56 Electron/28.0.0 Safari/537.36' \
  --data-raw '{"messages":[{"role":"user","content":"hello"}],"model":"databricks/dbrx-instruct","stream":false,"max_tokens":2048,"temperature":0.5,"top_p":1,"frequency_penalty":0,"presence_penalty":0,"stop":null}' \
  --compressed

chore: some small text update
d9b98f7 
- remove databrick since it does not work when I tested
- correct some texts
@namchuai namchuai marked this pull request as ready for review June 4, 2024 04:16
louis-jan
louis-jan approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit d6bd493 into janhq:dev Jun 4, 2024
7 checks passed
@namchuai namchuai mentioned this pull request Jun 4, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

@hiro-v hiro-v Awaiting requested review from hiro-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Realmbird @namchuai @louis-jan