Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop auto scroll if user manually scrolling up #2874

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: stop auto scroll if user manually scrolling up #2874

merged 1 commit into from
May 6, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented May 6, 2024 •
edited
Loading

Describe Your Changes

  • Stop auto scroll if user is scrolling up.
  • Fix issue press copy on message and the chat body scrolled down all to the bottom.

Videos

Screen.Recording.2024-05-06.at.18.45.21.mov

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label May 6, 2024
@namchuai namchuai requested a review from louis-jan May 6, 2024 11:49
@namchuai namchuai assigned urmauur and namchuai and unassigned urmauur and namchuai May 6, 2024
@namchuai namchuai requested review from Van-QA and urmauur May 6, 2024 11:50
@Van-QA
Copy link
Contributor

Van-QA commented May 6, 2024

potentially resolving #2847

@Van-QA Van-QA merged commit 0406b51 into dev May 6, 2024
9 checks passed
@Van-QA Van-QA deleted the fix/scroll-down-when-copy branch May 6, 2024 13:03
@github-actions github-actions bot added this to the v0.5.0 Broken Rice milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

@louis-jan louis-jan Awaiting requested review from louis-jan

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.13 🌾 Broken Rice
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@namchuai @Van-QA @urmauur