Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature windows nsis #2705

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Feature windows nsis #2705

merged 9 commits into from
Apr 17, 2024

Conversation

hiento09
Copy link
Collaborator

Describe Your Changes

Feature windows nsis

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Additional

image image image image

@hiento09 hiento09 added the type: feature request A new feature label Apr 12, 2024
@hiento09 hiento09 added this to the v0.4.12 milestone Apr 12, 2024
@hiento09 hiento09 requested a review from a team April 12, 2024 08:54
@hiento09 hiento09 self-assigned this Apr 12, 2024
@hiento09
Copy link
Collaborator Author

hiento09 commented Apr 15, 2024 •
edited
Loading

image
Enabling the oneclick install will confuse users because the auto-updater will also display similar dialogs. Therefore, I will disable these dialogs and only enable one notification for the user to agree to delete the jan data folder or not.

@Van-QA Van-QA mentioned this pull request Apr 16, 2024
Closed
6 tasks
@hiento09 hiento09 mentioned this pull request Apr 17, 2024
Closed
Van-QA
Van-QA approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the removal of default jan data folder in functioning

@hiento09 hiento09 merged commit 8820ad6 into dev Apr 17, 2024
7 checks passed
@hiento09 hiento09 deleted the feature/windows-nsis branch April 17, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

Assignees

@hiento09 hiento09

Labels
type: feature request A new feature
Projects
Jan & cortex.cpp
Archived in project
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

bug/feat: Windows uninstall should delete the Jan Data Folder
3 participants
@hiento09 @Van-QA @hientominh