Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not able to update model setting in local api #2687

Merged

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Apr 11, 2024

Describe Your Changes

  • Handle the model setting changes.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from louis-jan April 11, 2024 08:10
@github-actions github-actions bot added the type: bug Something isn't working label Apr 11, 2024
@Van-QA Van-QA changed the base branch from dev to release/0.4.11 April 11, 2024 08:15
@namchuai namchuai force-pushed the fix/not-able-update-engine-setting-localapi branch from 60df366 to 56dd725 Compare April 11, 2024 08:17
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit 3deaa8f into release/0.4.11 Apr 11, 2024
7 checks passed
@louis-jan louis-jan deleted the fix/not-able-update-engine-setting-localapi branch April 11, 2024 08:49
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants