Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better kill process tensorrt-llm #2681

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: better kill process tensorrt-llm #2681

merged 1 commit into from
Apr 11, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Sending a kill signal to the nitro instance will be queued and not processed until all inference requests are completed, which is inefficient. Attempting to kill the subprocesses directly could be a more efficient approach.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from a team April 11, 2024 05:09
@github-actions github-actions bot added the type: bug Something isn't working label Apr 11, 2024
@louis-jan louis-jan merged commit c0949b2 into dev Apr 11, 2024
9 checks passed
@louis-jan louis-jan deleted the fix/better-kill-process-tensorrt-llm branch April 11, 2024 05:47
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louis-jan @namchuai