Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nitro additional dependencies #2674

Merged
merged 1 commit into from
Apr 11, 2024
Merged

feat: nitro additional dependencies #2674

merged 1 commit into from
Apr 11, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Windows users would not be able to get GPU acceleration to work without the CUDA Toolkit installed on their machine. We now support allowing them to download the additional package for the Nitro extension to address this

Screenshot 2024-04-10 193646
Screenshot 2024-04-10 193653
Screenshot 2024-04-10 193950

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: feature request A new feature label Apr 10, 2024
@louis-jan louis-jan force-pushed the feat/nitro-additional-dependencies-cuda-toolkit branch from 88b5474 to 9e541a9 Compare April 10, 2024 12:48
@louis-jan louis-jan requested a review from a team April 10, 2024 12:48
@louis-jan louis-jan merged commit d93d74c into dev Apr 11, 2024
7 checks passed
@louis-jan louis-jan deleted the feat/nitro-additional-dependencies-cuda-toolkit branch April 11, 2024 02:13
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees

@louis-jan louis-jan

Labels
type: feature request A new feature
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louis-jan @namchuai