Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move log into monitoring extension #2662

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: move log into monitoring extension #2662

merged 1 commit into from
Apr 10, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Apr 9, 2024

Describe Your Changes

  • Introduce the Logger Module, where any extensions can register their own logging mechanisms (FS/S3/Prometheus, etc.) and have the ability to toggle on/off between loggers (at the extension setting level).
  • This PR is to move the logging mechanism out of the Electron app. The monitoring extension provides a default logging system using FS.
  • Introduce Logger, LogManager & Log Queue
  • Users can opt out of this default logger from the Settings Page (defaulted on).
  • Users can adjust the log cleaning interval (defaulted to 2 minutes).

image

Extension Settings:
image

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: feature request A new feature label Apr 9, 2024
@louis-jan louis-jan requested a review from a team April 9, 2024 10:38
@Van-QA Van-QA merged commit 3f23de6 into dev Apr 10, 2024
7 checks passed
@Van-QA Van-QA deleted the feat/log-refactoring branch April 10, 2024 07:35
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants