Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extension should register its own models #2601

Merged
merged 5 commits into from
Apr 5, 2024
Merged

chore: extension should register its own models #2601

merged 5 commits into from
Apr 5, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Apr 3, 2024 •
edited
Loading

Describe Your Changes

  • Extension register its own models.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from louis-jan April 3, 2024 11:02
@github-actions github-actions bot added the type: chore Maintenance, integration, packaging related label Apr 3, 2024
@namchuai namchuai force-pushed the chore/extension-register-its-models branch 2 times, most recently from b9dc2f6 to bb56b24 Compare April 4, 2024 04:12
@namchuai namchuai marked this pull request as ready for review April 4, 2024 07:47
@namchuai namchuai requested a review from a team April 4, 2024 07:47
@namchuai namchuai force-pushed the chore/extension-register-its-models branch from 43a33ac to c7d49b4 Compare April 4, 2024 07:51
@louis-jan
Copy link
Contributor

Update Dockerfile

COPY --from=builder /app/models ./models/

remove unwanted file
259fa71 
Signed-off-by: James <[email protected]>
@namchuai namchuai force-pushed the chore/extension-register-its-models branch from e8735df to 259fa71 Compare April 5, 2024 04:48
louis-jan
louis-jan approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit e0d6049 into dev Apr 5, 2024
7 checks passed
@namchuai namchuai deleted the chore/extension-register-its-models branch April 5, 2024 07:18
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: chore Maintenance, integration, packaging related
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namchuai @louis-jan