Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mistral inference engine extension #2569

Merged
merged 12 commits into from
Apr 9, 2024
Merged

feat: mistral inference engine extension #2569

merged 12 commits into from
Apr 9, 2024

Conversation

Inchoker
Copy link
Contributor

@Inchoker Inchoker commented Apr 2, 2024 •
edited
Loading

Describe Your Changes

  • Add new feature: inference mistral extension

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

image

image

@Inchoker Inchoker changed the title Feat/inference mistral extension Draft: Feat/inference mistral extension Apr 2, 2024
@Inchoker Inchoker changed the title Draft: Feat/inference mistral extension Feat/inference mistral extension Apr 3, 2024
@Inchoker Inchoker force-pushed the feat/inference-mistral-extension branch from 1f96cf8 to cc6c027 Compare April 3, 2024 02:53
@Inchoker Inchoker marked this pull request as ready for review April 3, 2024 02:53
@Inchoker Inchoker requested a review from louis-jan April 3, 2024 02:59
@louis-jan louis-jan changed the title Feat/inference mistral extension feat: mistral inference engine extension Apr 3, 2024
@louis-jan
Copy link
Contributor

louis-jan commented Apr 3, 2024 •
edited
Loading

Blocked by the registerModels feature implementation #2451

@Inchoker Inchoker force-pushed the feat/inference-mistral-extension branch from cc6c027 to 1cac045 Compare April 8, 2024 02:35
@Inchoker Inchoker force-pushed the feat/inference-mistral-extension branch from 1cac045 to ea45540 Compare April 8, 2024 10:29
louis-jan
louis-jan approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Inchoker Inchoker merged commit 1244f03 into dev Apr 9, 2024
7 checks passed
@Inchoker Inchoker deleted the feat/inference-mistral-extension branch April 9, 2024 04:18
@github-actions github-actions bot added this to the v0.4.11 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@Inchoker Inchoker

Labels
None yet
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

feat: please add cloud-api support for Mistral's 3 models feat: inference-mistral-extension
2 participants
@Inchoker @louis-jan