Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker build fails #2488

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: docker build fails #2488

merged 1 commit into from
Mar 25, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Mar 25, 2024 •
edited
Loading

Describe Your Changes

  • Since we have removed documents from the monorepo repository, we should keep Swagger API docs in the desktop project until we support auto-generating Swagger specs. It's also to address the broken build step.

Screenshot 2024-03-25 154325
Screenshot 2024-03-25 154346

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: chore Maintenance, integration, packaging related label Mar 25, 2024
@louis-jan louis-jan force-pushed the chore/add-api-docs-to-electron branch 3 times, most recently from bcfc0c9 to fcfe604 Compare March 25, 2024 07:29
@louis-jan louis-jan changed the title chore: add api docs to desktop app fix: docker build fails Mar 25, 2024
@louis-jan louis-jan force-pushed the chore/add-api-docs-to-electron branch from fcfe604 to 355d20b Compare March 25, 2024 08:30
@louis-jan louis-jan merged commit 50f819f into dev Mar 25, 2024
@louis-jan louis-jan deleted the chore/add-api-docs-to-electron branch March 25, 2024 08:46
@Van-QA
Copy link
Contributor

Van-QA commented Mar 27, 2024

linking to #2500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@hiento09 hiento09 hiento09 approved these changes

@urmauur urmauur Awaiting requested review from urmauur

Assignees

@louis-jan louis-jan

Labels
type: chore Maintenance, integration, packaging related
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@louis-jan @Van-QA @namchuai @hiento09