Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Refactoring the docs into the new page structure #2417

Merged
merged 17 commits into from
Mar 19, 2024
Merged

docs: Refactoring the docs into the new page structure #2417

merged 17 commits into from
Mar 19, 2024

Conversation

aindrajaya
Copy link
Contributor

Describe Your Changes

  • Refactored into the new page structure
  • Redirect the broken link to the new docs structure links
  • Hubpage change the link to the right path
  • Add the icon image for the changelog section

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@aindrajaya aindrajaya added type: documentation Improvements or additions to documentation roadmap: Jan Docs labels Mar 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Preview URL: https://43a100c7.jan-qn8.pages.dev

@henryh0x1
Copy link
Collaborator

For the icon of each changelog, could you create one icon that used for entire of the changelog (without version number inside icon). Thus, we can reduce the efforts for maintaining the changelog each time we release as we already implement auto fetch for content, so don't need to design icon too. @aindrajaya @irfanpena

@aindrajaya
Copy link
Contributor Author

Hi @hieu-jan I've already made an update for your feedback to change one icon for changelog.

@github-actions github-actions bot requested a deployment to jan (Preview) March 19, 2024 09:44 Abandoned
henryh0x1
henryh0x1 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@henryh0x1 henryh0x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henryh0x1 henryh0x1 merged commit d734c08 into dev Mar 19, 2024
1 check failed
@henryh0x1 henryh0x1 deleted the docs-pena-team branch March 19, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryh0x1 henryh0x1 henryh0x1 approved these changes

@0xSage 0xSage Awaiting requested review from 0xSage

@eckartal eckartal Awaiting requested review from eckartal

Assignees

@aindrajaya aindrajaya

@irfanpena irfanpena

Labels
roadmap: Jan Docs type: documentation Improvements or additions to documentation
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: adopt new guides layout
3 participants
@aindrajaya @henryh0x1 @irfanpena