Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback when WMIC is not installed on user's windows #2413

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Fallback when WMIC is not installed on user's windows.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Mar 18, 2024
@namchuai namchuai requested a review from louis-jan March 18, 2024 05:05
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit c5af694 into release/v0.4.9 Mar 18, 2024
5 checks passed
@namchuai namchuai deleted the fix/2201-regression branch March 18, 2024 06:11
Van-QA pushed a commit that referenced this pull request Mar 19, 2024
* fix: turn off experimental settings should also turn off quick ask (#2411)

* fix: app glitches 1s generating response before starting model (#2412)

* fix: disable experimental feature should also disable vulkan (#2414)

* fix: model load stuck on windows when can't get CPU core count (#2413)

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>

* feat: TensorRT-LLM engine update support (#2415)

* fix: engine update

* chore: add remove prepopulated models

Signed-off-by: James <[email protected]>

* update tinyjensen url

Signed-off-by: James <[email protected]>

* update llamacorn

Signed-off-by: James <[email protected]>

* update Mistral 7B Instruct v0.1 int4

Signed-off-by: James <[email protected]>

* update tensorrt

Signed-off-by: James <[email protected]>

* update

Signed-off-by: hiro <[email protected]>

* update

Signed-off-by: James <[email protected]>

* prettier

Signed-off-by: James <[email protected]>

* update mistral config

Signed-off-by: James <[email protected]>

* fix some lint

Signed-off-by: James <[email protected]>

---------

Signed-off-by: James <[email protected]>
Signed-off-by: hiro <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiro <[email protected]>

* Tensorrt LLM disable turing support (#2418)

Co-authored-by: Hien To <[email protected]>

* chore: add prompt template tensorrtllm (#2375)

* chore: add prompt template tensorrtllm

* Add Prompt template for mistral and correct model metadata

---------

Co-authored-by: Hien To <[email protected]>

* fix: correct tensorrt mistral model.json (#2419)

---------

Signed-off-by: James <[email protected]>
Signed-off-by: hiro <[email protected]>
Co-authored-by: Louis <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiro <[email protected]>
Co-authored-by: hiento09 <136591877 [email protected]>
Co-authored-by: Hien To <[email protected]>
Van-QA pushed a commit that referenced this pull request Mar 19, 2024
* fix: move tensorrt executable to engine (#2400)

* fix: move tensorrt executable to engine

Signed-off-by: James <[email protected]>

* some update

Signed-off-by: hiro <[email protected]>

* chore: bump tensorrt version

* fix: wrong destroy path

* fix: install extensions in parallel

* chore: update path for tensorrt engine (#2404)

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>

---------

Signed-off-by: James <[email protected]>
Signed-off-by: hiro <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiro <[email protected]>
Co-authored-by: Louis <[email protected]>

* Release/v0.4.9 (#2421)

* fix: turn off experimental settings should also turn off quick ask (#2411)

* fix: app glitches 1s generating response before starting model (#2412)

* fix: disable experimental feature should also disable vulkan (#2414)

* fix: model load stuck on windows when can't get CPU core count (#2413)

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>

* feat: TensorRT-LLM engine update support (#2415)

* fix: engine update

* chore: add remove prepopulated models

Signed-off-by: James <[email protected]>

* update tinyjensen url

Signed-off-by: James <[email protected]>

* update llamacorn

Signed-off-by: James <[email protected]>

* update Mistral 7B Instruct v0.1 int4

Signed-off-by: James <[email protected]>

* update tensorrt

Signed-off-by: James <[email protected]>

* update

Signed-off-by: hiro <[email protected]>

* update

Signed-off-by: James <[email protected]>

* prettier

Signed-off-by: James <[email protected]>

* update mistral config

Signed-off-by: James <[email protected]>

* fix some lint

Signed-off-by: James <[email protected]>

---------

Signed-off-by: James <[email protected]>
Signed-off-by: hiro <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiro <[email protected]>

* Tensorrt LLM disable turing support (#2418)

Co-authored-by: Hien To <[email protected]>

* chore: add prompt template tensorrtllm (#2375)

* chore: add prompt template tensorrtllm

* Add Prompt template for mistral and correct model metadata

---------

Co-authored-by: Hien To <[email protected]>

* fix: correct tensorrt mistral model.json (#2419)

---------

Signed-off-by: James <[email protected]>
Signed-off-by: hiro <[email protected]>
Co-authored-by: Louis <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiro <[email protected]>
Co-authored-by: hiento09 <136591877 [email protected]>
Co-authored-by: Hien To <[email protected]>

---------

Signed-off-by: James <[email protected]>
Signed-off-by: hiro <[email protected]>
Co-authored-by: NamH <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiro <[email protected]>
Co-authored-by: hiento09 <136591877 [email protected]>
Co-authored-by: Hien To <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants