Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean working dir with long space support on Windows #2399

Merged
merged 1 commit into from
Mar 17, 2024
Merged

fix: clean working dir with long space support on Windows #2399

merged 1 commit into from
Mar 17, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Mar 17, 2024 •
edited
Loading

Describe Your Changes

  • CI might fail due to long file path on Windows.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested a review from hiento09 March 17, 2024 03:53
@github-actions github-actions bot added the type: bug Something isn't working label Mar 17, 2024
@louis-jan louis-jan force-pushed the fix/clean-working-dir-windows branch from 6554b5d to 9ffab49 Compare March 17, 2024 03:54
@louis-jan louis-jan force-pushed the fix/clean-working-dir-windows branch from 9ffab49 to bbb4e8b Compare March 17, 2024 03:55
hiento09
hiento09 approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@louis-jan louis-jan merged commit e74345e into dev Mar 17, 2024
6 of 7 checks passed
@louis-jan louis-jan deleted the fix/clean-working-dir-windows branch March 17, 2024 04:22
@Van-QA Van-QA added this to the v0.4.9 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
v0.4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-jan @hiento09 @Van-QA