Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image upload button and drag event are not enabled #2248

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Mar 5, 2024

Describe Your Changes

  • Fixed the conditions to enable image upload button and drag image to upload action
  • Bump model extension version so model.json will be migrated

Vision Model is enabled
Screenshot 2024-03-05 at 20 24 40

Screenshot 2024-03-05 at 20 27 52

Vision Model is disabled
Screenshot 2024-03-05 at 20 29 19

RAG & Vision are disabled
Screenshot 2024-03-05 at 20 29 25

Tooltips
Screenshot 2024-03-05 at 21 03 28
Screenshot 2024-03-05 at 21 03 38

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan requested review from urmauur and Van-QA March 5, 2024 13:27
@github-actions github-actions bot added the type: bug Something isn't working label Mar 5, 2024
@louis-jan louis-jan force-pushed the fix/jan-can-see-visibility branch 2 times, most recently from c058986 to db7ce64 Compare March 5, 2024 14:03
@louis-jan louis-jan merged commit 5ca3069 into dev Mar 6, 2024
7 checks passed
@louis-jan louis-jan deleted the fix/jan-can-see-visibility branch March 6, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants