Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add import model feature #2104

Merged
merged 1 commit into from
Feb 26, 2024
Merged

feat: add import model feature #2104

merged 1 commit into from
Feb 26, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Feb 20, 2024 •
edited
Loading

Describe Your Changes

  • Adding import model feature from UI.

Videos

Screen.Recording.2024-02-21.at.01.24.30.mov

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: feature request A new feature label Feb 20, 2024
@namchuai namchuai force-pushed the feat/import-model branch 3 times, most recently from b1840eb to 820cc12 Compare February 20, 2024 16:49
@namchuai namchuai force-pushed the feat/import-model branch 6 times, most recently from b5c8efe to aa16f10 Compare February 22, 2024 18:07
@namchuai namchuai marked this pull request as ready for review February 22, 2024 18:07
@louis-jan
Copy link
Contributor

louis-jan commented Feb 23, 2024 •
edited
Loading

  1. Click "Import", select and file and stuck there (works great with drag & drop)
Screenshot 2024-02-23 at 11 07 50
  1. Can't see title (dark mode issue)
Screenshot 2024-02-23 at 11 08 04

3.Can't see progress & edit button (dark mode issue)
Screenshot 2024-02-23 at 11 08 26

  1. Drag file to model list: copy - file & folder (we don't support folder)

I see problems with dark mode here and there

@namchuai namchuai force-pushed the feat/import-model branch 2 times, most recently from db2d61e to 124f06a Compare February 25, 2024 16:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2024 •
edited
Loading

Preview URL: https://d46ba199.jan-qn8.pages.dev

louis-jan
louis-jan approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 773963a into dev Feb 26, 2024
7 checks passed
@namchuai namchuai deleted the feat/import-model branch February 26, 2024 09:15
@Van-QA Van-QA added this to the v0.4.8 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: feature request A new feature
Projects
Jan Project
Archived in project
Milestone
v0.4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@namchuai @louis-jan @Van-QA