Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decouple thread summary update #1994

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix: decouple thread summary update #1994

merged 1 commit into from
Feb 11, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Feb 11, 2024 •
edited
Loading

Describe Your Changes

  1. Decouple thread message and title update logic
  2. Fixed an issue where thread title could be undefined
  3. Thread summary should be a non streaming request
  4. Summary the entire thread messages instead of the first prompt

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Feb 11, 2024
@louis-jan louis-jan force-pushed the fix/decouple-thread-title-update branch 3 times, most recently from f9720c0 to 2784cc7 Compare February 11, 2024 09:29
@louis-jan louis-jan force-pushed the fix/decouple-thread-title-update branch from 2784cc7 to 2aea9e6 Compare February 11, 2024 09:30
@louis-jan louis-jan merged commit ac18fc1 into dev Feb 11, 2024
7 checks passed
@louis-jan louis-jan deleted the fix/decouple-thread-title-update branch February 11, 2024 13:22
@0xSage 0xSage mentioned this pull request Feb 14, 2024
Closed
@louis-jan louis-jan added this to the v0.4.7 milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

@0xgokuz 0xgokuz 0xgokuz approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-jan @urmauur @0xgokuz