Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative solution for Thread titles should auto-summarize Topic #1976

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Alternative solution for Thread titles should auto-summarize Topic #1976

merged 1 commit into from
Feb 10, 2024

Conversation

0xgokuz
Copy link
Contributor

@0xgokuz 0xgokuz commented Feb 9, 2024 •
edited
Loading

Fixed Issue: #979

Alternative solution of #1803

@louis-jan @hiro-v @urmauur

Still trying to figure out the race conditions, and a way to update the title in real-time

@louis-jan louis-jan mentioned this pull request Feb 9, 2024
Closed
@0xgokuz 0xgokuz force-pushed the feat-979b branch 2 times, most recently from 586d105 to 53748e5 Compare February 10, 2024 08:35
@0xgokuz 0xgokuz changed the title [WIP] Alternative solution for Thread titles should auto-summarize Topic Alternative solution for Thread titles should auto-summarize Topic Feb 10, 2024
louis-jan
louis-jan approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xgokuz 0xgokuz force-pushed the feat-979b branch 2 times, most recently from 665d00c to 3d75bc1 Compare February 10, 2024 09:52
@0xgokuz 0xgokuz force-pushed the feat-979b branch 2 times, most recently from e793c9e to 369a180 Compare February 10, 2024 11:18
@louis-jan louis-jan merged commit 875c2bc into janhq:dev Feb 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur left review comments

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xgokuz @urmauur @louis-jan