Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update success/failed download state #1945

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Feb 6, 2024

Describe Your Changes

  • For now download model would stuck at 9x% since the download success / failed is not well handled. This PR is to address this issue.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Feb 6, 2024
@louis-jan louis-jan marked this pull request as ready for review February 7, 2024 03:25
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit 20b75cb into fix/server-download-progress Feb 7, 2024
@louis-jan louis-jan deleted the fix/download-success-failed branch February 7, 2024 05:20
louis-jan added a commit that referenced this pull request Feb 7, 2024
* fix: update success/failed download state

Signed-off-by: James <[email protected]>

* fix: download model progress and state handling for both Desktop and Web

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Louis <[email protected]>
louis-jan added a commit that referenced this pull request Feb 7, 2024
* fix: update success/failed download state

Signed-off-by: James <[email protected]>

* fix: download model progress and state handling for both Desktop and Web

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Louis <[email protected]>
louis-jan added a commit that referenced this pull request Feb 7, 2024
* fix: update success/failed download state

Signed-off-by: James <[email protected]>

* fix: download model progress and state handling for both Desktop and Web

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Louis <[email protected]>
@Van-QA Van-QA added this to the v0.4.7 milestone Feb 7, 2024
hiento09 pushed a commit that referenced this pull request Feb 7, 2024
* fix: update success/failed download state

Signed-off-by: James <[email protected]>

* fix: download model progress and state handling for both Desktop and Web

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Louis <[email protected]>
louis-jan added a commit that referenced this pull request Feb 7, 2024
* fix: reduce the number of api call

Signed-off-by: James <[email protected]>

* fix: download progress

Signed-off-by: James <[email protected]>

* chore: save blob

* fix: server boot up

* fix: download state not updating

Signed-off-by: James <[email protected]>

* fix: copy assets

* Add Dockerfile CPU for Jan Server and Jan Web

* Add Dockerfile GPU for Jan Server and Jan Web

* feat: S3 adapter

* Update check find count from ./pre-install and correct copy:asserts command

* server add bundleDependencies @janhq/core

* server add bundleDependencies @janhq/core

* fix: update success/failed download state (#1945)

* fix: update success/failed download state

Signed-off-by: James <[email protected]>

* fix: download model progress and state handling for both Desktop and Web

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Louis <[email protected]>

* chore: refactor

* fix: load models empty first time open

* Add Docker compose

* fix: assistants onUpdate

---------

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: Hien To <[email protected]>
Co-authored-by: NamH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants