-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: server download progress S3 #1925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
Maintenance, integration, packaging related
label
Feb 5, 2024
louis-jan
force-pushed
the
fix/server-download-progress
branch
from
February 5, 2024 06:08
2ee92a0
to
7768fee
Compare
louis-jan
force-pushed
the
fix/server-download-progress
branch
7 times, most recently
from
February 5, 2024 13:17
6295e72
to
8a62b1b
Compare
louis-jan
force-pushed
the
fix/server-download-progress
branch
from
February 6, 2024 04:41
db60595
to
863058e
Compare
louis-jan
changed the title
chore: server download progress
chore: server download progress S3
Feb 6, 2024
louis-jan
force-pushed
the
fix/server-download-progress
branch
2 times, most recently
from
February 6, 2024 15:34
bdfab6d
to
2c0ebe3
Compare
louis-jan
force-pushed
the
fix/server-download-progress
branch
4 times, most recently
from
February 7, 2024 07:24
b3d4f61
to
55287b8
Compare
hiento09
force-pushed
the
fix/server-download-progress
branch
from
February 7, 2024 08:35
7142595
to
9684907
Compare
hiento09
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
namchuai
approved these changes
Feb 7, 2024
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
* fix: update success/failed download state Signed-off-by: James <[email protected]> * fix: download model progress and state handling for both Desktop and Web --------- Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: Louis <[email protected]>
hiento09
force-pushed
the
fix/server-download-progress
branch
from
February 7, 2024 08:57
46898d1
to
14f728a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist