Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken manual import model with NA fields #1912

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Feb 3, 2024

Describe Your Changes

Root cause: multiple model binaries support update added new N/A fields, which must be overwritten.

Here is the generated model.json with the fix

Screenshot 2024-02-03 at 14 36 47

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Feb 3, 2024
@louis-jan louis-jan merged commit afa80b9 into main Feb 3, 2024
7 checks passed
@louis-jan louis-jan deleted the regression/fix-broken-manual-import-model branch February 3, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants