feat: Thread titles should auto-summarize Topic #1803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xgokuz
force-pushed
the
feat-979
branch
10 times, most recently
from
36acb05
to
84b5e60
Compare
0xgokuz
changed the title
0xgokuz
force-pushed
the
feat-979
branch
9 times, most recently
from
b6e6552
to
b291e86
Compare
hiro-v
approved these changes
Feb 1, 2024
0xgokuz
force-pushed
the
feat-979
branch
5 times, most recently
from
96b595a
to
dd3d6ae
Compare
louis-jan
reviewed
Feb 3, 2024
louis-jan
reviewed
Feb 4, 2024
| @@ -5,4 5,8 @@ export enum MessageEvent { | |||
| OnMessageResponse = 'OnMessageResponse', | |||
| /** The `OnMessageUpdate` event is emitted when a message is updated. */ | |||
| OnMessageUpdate = 'OnMessageUpdate', | |||
|
|
|||
| OnFirstPrompt = 'OnFirstPrompt', | |||
There was a problem hiding this comment.
I think we can avoid code duplication. Let's say we can remove these, also, instead of onFirstPrompt, add a message type into MessageRequestBody, and the app's EventHandler can switch logics there. The PR would be very short and clean then.
|
Since #1976 would be a cleaner one, let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #979
The only thing I'm unsure is EventHandler.tsx