Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server API reference #1670

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix: server API reference #1670

merged 5 commits into from
Jan 22, 2024

Conversation

hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Jan 19, 2024

Describe Your Changes

  • API Reference local should point to local swagger instead of jan.ai remote documentation which is not interactive.
  • Only render API reference button is serverEnabled is true

Fixes Issues

Context: https://discord.com/channels/1107178041848909847/1187243133386375208/1197768679631372329

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiro-v hiro-v requested a review from a team January 19, 2024 08:27
@hiro-v hiro-v self-assigned this Jan 19, 2024
@hiro-v hiro-v changed the base branch from main to dev January 19, 2024 08:28
Copy link
Contributor

github-actions bot commented Jan 19, 2024

Preview URL: https://f5da6c6f.jan-qn8.pages.dev

@hiro-v hiro-v requested a review from louis-jan January 19, 2024 09:14
@hiro-v hiro-v requested review from a team and louis-jan and removed request for louis-jan January 20, 2024 15:36
@louis-jan louis-jan changed the title Fix/server api reference fix: server API reference Jan 22, 2024
@hiro-v hiro-v requested a review from louis-jan January 22, 2024 05:17
</Button>
{serverEnabled && (
<Button block themes="secondaryBlue" asChild>
<a href={`http://${host}:${port}`} target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiro-v hiro-v merged commit 4cf6df1 into dev Jan 22, 2024
0 of 6 checks passed
@hiro-v hiro-v deleted the fix/server_api_reference branch January 22, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants