Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update 02-somethings-amiss #1668

Merged
merged 2 commits into from
Jan 20, 2024
Merged

docs: update 02-somethings-amiss #1668

merged 2 commits into from
Jan 20, 2024

Conversation

henryh0x1
Copy link
Contributor

@henryh0x1 henryh0x1 commented Jan 18, 2024 •
edited
Loading

Describe Your Changes

  • Add additional reasons to somethings amiss

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@henryh0x1 henryh0x1 requested a review from 0xSage January 18, 2024 15:19
@henryh0x1 henryh0x1 requested a review from Van-QA January 18, 2024 15:19
@github-actions github-actions bot added the type: docs Improvements or additions to documentation label Jan 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited
Loading

Preview URL: https://e4baaa79.jan-qn8.pages.dev

Van-QA
Van-QA approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henryh0x1 henryh0x1 merged commit f17cf29 into dev Jan 20, 2024
1 check passed
@henryh0x1 henryh0x1 deleted the docs/add-additional-reasons branch January 20, 2024 05:09
@henryh0x1 henryh0x1 mentioned this pull request Jan 22, 2024
Closed
3 tasks
@louis-jan louis-jan mentioned this pull request Feb 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

@0xSage 0xSage Awaiting requested review from 0xSage

Assignees

@henryh0x1 henryh0x1

Labels
type: docs Improvements or additions to documentation
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryh0x1 @Van-QA