Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce node module in nitro extension #1630

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jan 16, 2024

Describe Your Changes

  • Refactor to have node module exported from extension, no more module.ts
  • Only ES syntax
  • No more require, just import
  • Since its node module, can import any ts files (module.ts can't import other ts files before)
  • Replaced webpack by rollup.js to support multiple exported modules (browser / node)
  • Move dev dependencies accordingly
typescript-extension:
   ├── package.json
   ├── node
   │   └──  index.ts // node module
   └── index.ts      // extension browser module

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: chore Maintenance, operational label Jan 16, 2024
@louis-jan louis-jan force-pushed the refactor/node-module-nitro-extension branch 5 times, most recently from 9c6e649 to 24abde4 Compare January 16, 2024 14:36
@louis-jan louis-jan force-pushed the refactor/node-module-nitro-extension branch 8 times, most recently from 7f304e7 to 92eb396 Compare January 17, 2024 04:10
@louis-jan louis-jan force-pushed the refactor/node-module-nitro-extension branch from 92eb396 to 2cc915a Compare January 17, 2024 04:12
@louis-jan louis-jan merged commit f4f861d into dev Jan 17, 2024
@louis-jan louis-jan deleted the refactor/node-module-nitro-extension branch January 17, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants