Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: issues should auto close with PRs through template #1577

Merged
merged 1 commit into from
Jan 14, 2024
Merged

chore: issues should auto close with PRs through template #1577

merged 1 commit into from
Jan 14, 2024

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Jan 14, 2024

Describe Your Changes

  • need specific syntax for github to auto close issues from merged PRs
  • pls auto merge for me.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@0xSage 0xSage requested a review from a team January 14, 2024 14:56
@github-actions github-actions bot added the type: chore Maintenance, integration, packaging related label Jan 14, 2024
hiento09
hiento09 approved these changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Van-QA
Copy link
Contributor

Van-QA commented Jan 14, 2024

@0xSage we might want to reconsider this, as merged PR will only mean it's now in nightly build and will need a double check just in case there are edge cases remaining.
On the other hand, the ticket should remain open until it's released to avoid causing confusion for users.

@0xSage 0xSage merged commit f18c2d2 into main Jan 14, 2024
2 checks passed
@0xSage 0xSage deleted the 0xSage-patch-1 branch January 14, 2024 15:21
@0xSage
Copy link
Contributor Author

0xSage commented Jan 14, 2024

@0xSage we might want to reconsider this, as merged PR will only mean it's now in nightly build and will need a double check just in case there are edge cases remaining. On the other hand, the ticket should remain open until it's released to avoid causing confusion for users.

I like this discussion a lot. pls bring up during standup or in a eng sync. I'm happy to go with what the group decides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees

@0xSage 0xSage

Labels
type: chore Maintenance, integration, packaging related
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xSage @Van-QA @hiento09