Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Thread): #1212 thread.json not created when user change thread settings #1570

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Store the thread file when user change thread settings.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

core/src/node/api/common/builder.ts Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 4a2f5bc into main Jan 14, 2024
8 of 9 checks passed
@namchuai namchuai deleted the fix/1212 branch January 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants