Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gpu check module export does not work in extension #1536

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: gpu check module export does not work in extension #1536

merged 1 commit into from
Jan 11, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jan 11, 2024 •
edited
Loading

Describe Your Changes

  • Revert back gpu check modular, should work on proper bundler so can export both browser and nodejs module such as core

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Jan 11, 2024
@louis-jan louis-jan merged commit dbd8740 into main Jan 11, 2024
7 checks passed
@louis-jan louis-jan deleted the fix/gpu-utility-module-export branch January 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiento09 hiento09 hiento09 approved these changes

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louis-jan @hiento09