Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop word update #1457

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix: stop word update #1457

merged 2 commits into from
Jan 11, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jan 8, 2024 •
edited
Loading

Describe Your Changes

  • Add stop word for the prompt template correction.
  • Enable stop settings and correct request body to send stop words array
  • Fix "Show in Finder" title according to platform specific

Self Checklist

  • break the update from chore/hotfix-modelhub

@louis-jan louis-jan marked this pull request as ready for review January 8, 2024 15:23
@github-actions github-actions bot added the type: bug Something isn't working label Jan 8, 2024
@louis-jan louis-jan force-pushed the chore/hot-fix-modelhub branch 2 times, most recently from 33230d5 to c3018cf Compare January 8, 2024 15:34
Base automatically changed from chore/hot-fix-modelhub to main January 8, 2024 16:00
@louis-jan louis-jan marked this pull request as draft January 10, 2024 06:25
@louis-jan louis-jan marked this pull request as ready for review January 10, 2024 07:40
@louis-jan louis-jan merged commit 19153c4 into main Jan 11, 2024
5 checks passed
@louis-jan louis-jan deleted the fix/stop-word-update branch January 11, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees

@hahuyhoang411 hahuyhoang411

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louis-jan @namchuai @hahuyhoang411