Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1183 Reveal in finder does not work on windows #1239

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Conversation

namchuai
Copy link
Contributor

fixes #1183

@github-actions github-actions bot added the type: bug Something isn't working label Dec 28, 2023
@namchuai namchuai changed the title fix: #1183 Reveal in finder does not work on windows Draft: fix: #1183 Reveal in finder does not work on windows Dec 28, 2023
James added 2 commits December 28, 2023 12:29
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai changed the title Draft: fix: #1183 Reveal in finder does not work on windows fix: #1183 Reveal in finder does not work on windows Dec 28, 2023
@namchuai namchuai merged commit cbc63da into main Dec 28, 2023
5 checks passed
@namchuai namchuai deleted the fix/1183 branch December 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Reveal in Finder does not work in Windows, it has wrong slashes in the dir path
2 participants