Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable enter command on dialog confirmation delete thread #1218

Merged
merged 2 commits into from
Dec 27, 2023
Merged

fix: enable enter command on dialog confirmation delete thread #1218

merged 2 commits into from
Dec 27, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 26, 2023

fixes #1188

Test

  • Create thread and try delete thread, when dialog confirmation shown hit enter, thread should be deleted
Screen.Recording.2023-12-26.at.22.18.45.mov

@github-actions github-actions bot added the type: bug Something isn't working label Dec 26, 2023
@louis-jan louis-jan merged commit 7c1d1ef into main Dec 27, 2023
5 checks passed
@louis-jan louis-jan deleted the fix/delete-thread branch December 27, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: delete threads only work when i click "yes" on confirmation pop-up, not working when i hit enter
2 participants
@urmauur @louis-jan