Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove delay tooltip and click event #1217

Merged
merged 1 commit into from
Dec 27, 2023
Merged

fix: remove delay tooltip and click event #1217

merged 1 commit into from
Dec 27, 2023

Conversation

urmauur
Copy link
Contributor

@urmauur urmauur commented Dec 26, 2023

fixes #1190

Test scenario

  • Chat with local model
  • Try hovering on model setting with disabled input
  • Make sure show a tooltip when hover and no delay, and when you try click the input disabled tooltip should be not disapear

Screenshot

Screenshot 2023-12-26 at 21 19 47

@urmauur urmauur added the type: bug Something isn't working label Dec 26, 2023
@urmauur urmauur self-assigned this Dec 26, 2023
@louis-jan
Copy link
Contributor

As users can now change models mid-thread, there's no need to fix the tooltip.

@urmauur
Copy link
Contributor Author

urmauur commented Dec 27, 2023

@louis-jan i have changes on tooltip component, so i think we still need deliver this for avoid the delayed on tooltip, we use tooltip also on ribbon panel, i'll resolve conflict first

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update

@urmauur urmauur merged commit 959bae3 into main Dec 27, 2023
5 checks passed
@urmauur urmauur deleted the fix/tooltip-delay branch December 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
2 participants