fix: #1096 yield error message upon thread switching #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imtuyethan please see attached video |
louis-jan
force-pushed
the
fix/1096-yield-error-upon-thread-switching
branch
from
e87aeee
to
4f63cad
Compare
namchuai
approved these changes
Dec 20, 2023
louis-jan
force-pushed
the
fix/1096-yield-error-upon-thread-switching
branch
from
4f63cad
to
46708ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on issues #1096 and #1098, the chat completion process is currently interrupted when a user switches to another thread. This pull request aims to add a new message state called "Error" and abort ongoing chat completion requests when there is an active thread change. It will then display an appropriate error message and regenerate the options.
The update is applied to 3 following extensions:
Untitled.mov
Unrelated changes
Related issues
fixes #1096
fixes #1098