Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Should be able to stop the inference #385

Closed
tikikun opened this issue Oct 18, 2023 · 3 comments
Closed

feat: Should be able to stop the inference #385

tikikun opened this issue Oct 18, 2023 · 3 comments
Assignees
@urmauur
Labels
good first issue Good for newcomers P1: important Important feature / fix type: feature request A new feature
Milestone
0.4.0

Comments

@tikikun
Copy link
Contributor

tikikun commented Oct 18, 2023

Problem
Sometimes the inference has issue, i want to stop it half way through

Success Criteria
Have a stop button like chatGPT

image
@tikikun tikikun added the type: feature request A new feature label Oct 18, 2023
@0xSage 0xSage added the P3: nice to have Nice to have feature label Oct 18, 2023
@0xSage
Copy link
Contributor

0xSage commented Oct 18, 2023

It seems Nitro already supports this. #141

Hopefully a quick implementation!

@0xSage 0xSage added P1: important Important feature / fix good first issue Good for newcomers and removed P3: nice to have Nice to have feature labels Oct 18, 2023
@hiro-v hiro-v added this to the Jan V2.0.0 milestone Oct 22, 2023
@0xSage 0xSage assigned urmauur and hiro-v and unassigned hiro-v and louis-jan Nov 13, 2023
@0xSage 0xSage removed this from the Jan V2.0.0 milestone Nov 22, 2023
@louis-jan
Copy link
Contributor

Updated inference module. #677

from UI

pluginManager.get<InferencePlugin>(PluginType.Inference).stopInference()

@louis-jan louis-jan mentioned this issue Nov 24, 2023
Merged
@louis-jan
Copy link
Contributor

Added in this PR:
#717

@0xSage 0xSage added this to the v0.4.0 milestone Nov 27, 2023
@urmauur urmauur mentioned this issue Nov 27, 2023
Merged
@urmauur urmauur closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urmauur urmauur

Labels
good first issue Good for newcomers P1: important Important feature / fix type: feature request A new feature
Projects
Jan Project
Archived in project
Milestone
0.4.0
Development

No branches or pull requests
5 participants
@urmauur @tikikun @hiro-v @0xSage @louis-jan